exercises(triangle): return an optional, not an error union #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We simplified the error set to contain only one error [1], so there's an argument to use an optional instead. [1] 4a4665a exercises(triangle): simplify error set (2023-03-12) Refs: exercism#229
ee7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We simplified the error set to contain only one error (4a4665a), so there's an argument to use an optional instead.
Refs: #229
Thoughts on whether this is an improvement? I'm not convinced for this particular exercise. Basically, if you call
initwith some strange side lengths, do you want an error ornull?I'll did this to see what it'd look like as
null, but I'm leaning towards closing this PR. We can reopen it if we feel it's worth considering.